netdev - Re: Question regarding MAC address configuraton with VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408092016.GA27193@unicorn.suse.cz>
Date:	Wed, 8 Apr 2015 11:20:16 +0200
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Manish Chopra <manish.chopra@...gic.com>,
	Patrick McHardy <kaber@...sh.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Question regarding MAC address configuraton with VLAN devices

On Wed, Apr 08, 2015 at 05:49:59AM +0000, Yuval Mintz wrote:
> I think there's an even simpler question here -
> Today, if you'll have a network interface with a vlan stacked on top of it
> and user calls 'ip link set ... address ...' the end result would be that the vlan
> interface retains the original MAC and push it downward [to base device].
> You can claim this is harmless, but I don't really think anyone intends this to
> happen.

If it wasn't intended, why would anyone write the code doing the sync
(and switching to promiscuous mode as a fallback)? The way I see it,
there were two options:

  (a) add upper device's address to lower device's uc list
  (b) propagate changed MAC address upwards

And the decision was to choose (a). While (b) might make some things
simpler (and others more complicated), changing the behaviour now when
people are used to it would be IMHO very unfortunate.

                                                        Michal Kubecek
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html