netdev - Re: [PATCH net] udptunnels: Call handle_offloads after inserting vlan tag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150409.145709.1076905748131956555.davem@davemloft.net>
Date:	Thu, 09 Apr 2015 14:57:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] udptunnels: Call handle_offloads after inserting
 vlan tag.

From: Jesse Gross <jesse@...ira.com>
Date: Thu,  9 Apr 2015 11:19:14 -0700

> handle_offloads() calls skb_reset_inner_headers() to store
> the layer pointers to the encapsulated packet. However, we
> currently push the vlag tag (if there is one) onto the packet
> afterwards. This changes the MAC header for the encapsulated
> packet but it is not reflected in skb->inner_mac_header, which
> breaks GSO and drivers which attempt to use this for encapsulation
> offloads.
> 
> Fixes: 1eaa8178 ("vxlan: Add tx-vlan offload support.")
> Signed-off-by: Jesse Gross <jesse@...ira.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html