netdev - Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428543798.4720.20.camel@prashant>
Date:	Wed, 8 Apr 2015 18:43:18 -0700
From:	Prashant Sreedharan <prashant@...adcom.com>
To:	Ian Jackson <Ian.Jackson@...citrix.com>
CC:	Michael Chan <mchan@...adcom.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>,
	Vlad Yasevich <vyasevich@...il.com>,
	"Nithin Nayak Sujir" <nsujir@...adcom.com>,
	<xen-devel@...ts.xensource.com>, <netdev@...r.kernel.org>
Subject: Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

On Wed, 2015-04-08 at 14:59 +0100, Ian Jackson wrote:
> Thanks to Konrad, Michael and Prashant for your attention.
> 
> 
> Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> > Ian, in your previous mail you indicated there are no drops or errors
> > reported on eth0 (assuming this is the tg3 port), which is added to the
> > bridge xenbr0 is this correct ?
> 
> Yes, that is correct.
> 
> > If so the rx drops on xenbr0 does not match with eth0.  please also
> > provide "brctl show", "ethtool -i eth0"
> 
> root@...bug:~# brctl show
> bridge name     bridge id               STP enabled     interfaces
> xenbr0          8000.00137214c051       no              eth0
> root@...bug:~# ethtool -i eth0
> driver: tg3
> version: 3.136
> firmware-version: 5751-v3.44a
> bus-info: 0000:03:00.0
> supports-statistics: yes
> supports-test: yes
> supports-eeprom-access: yes
> supports-register-dump: yes
> supports-priv-flags: no
> root@...bug:~#
> 
> 
> Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> > On Tue, 2015-04-07 at 19:13 +0100, Ian Jackson wrote:
> > > root@...bug:~# ethtool -S xenbr0 | grep -v ': 0$'
> > > no stats available
> > > root@...bug:~# 
> > 
> > Please provide ethtool -S on the tg3 device.
> 
> I did that in my previous email.  Let me recap:
> 
> Ian Jackson writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> > Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> > > Please provide the output of "ethtool -S" which has a better breakdown
> > > of the error counters.  Thanks.
> > 
> > root@...bug:~# ethtool -S eth0 | grep -v ': 0$'
> > NIC statistics:
> >      rx_octets: 793954
> >      rx_ucast_packets: 342
> >      rx_mcast_packets: 197
> >      rx_bcast_packets: 11049
> >      tx_octets: 59093
> >      tx_ucast_packets: 396
> >      tx_mcast_packets: 8
> >      tx_bcast_packets: 4
> > root@...bug:~# ifconfig eth0
> > eth0      Link encap:Ethernet  HWaddr 00:13:72:14:c0:51  
> >           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
> >           RX packets:16012 errors:0 dropped:0 overruns:0 frame:0
> >           TX packets:459 errors:0 dropped:0 overruns:0 carrier:0
> >           collisions:0 txqueuelen:1000 
> >           RX bytes:1090543 (1.0 MiB)  TX bytes:64575 (63.0 KiB)
> >           Interrupt:17 
> > 
> > root@...bug:~# 
> > 
> > And:
> > 
> > --- bedbug.cam.xci-test.com ping statistics ---
> > 120 packets transmitted, 90 received, 25% packet loss, time 119354ms
> > rtt min/avg/max/mdev = 0.294/0.459/0.844/0.073 ms
> > 
> > 
> > Evidently on this particular kernel, the error counters are _not_
> > increasing, contrary to what I said before.  I confess that I didn't
> > keep a record of on which particular machine and kernel I observed the
> > error count increasing.
> > 
> > If it would help I could try to check various other machines and/or
> > other kernels to see if I can get one of them to display the error
> > counter behaviour.
> 
> 
> Ian Jackson writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> > I just realised that I didn't check xenbr0 as well as eth0:
> > 
> > root@...bug:~# ifconfig xenbr0
> > xenbr0    Link encap:Ethernet  HWaddr 00:13:72:14:c0:51  
> >           inet addr:10.80.249.102  Bcast:10.80.251.255
> >           Mask:255.255.252.0
> >           inet6 addr: fe80::213:72ff:fe14:c051/64 Scope:Link
> >           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
> >           RX packets:12296 errors:0 dropped:793 overruns:0 frame:0
> >           TX packets:437 errors:0 dropped:0 overruns:0 carrier:0
> >           collisions:0 txqueuelen:0 
> >           RX bytes:618757 (604.2 KiB)  TX bytes:49084 (47.9 KiB)
> > 
> > root@...bug:~# ethtool -S xenbr0 | grep -v ': 0$'
> > no stats available
> > root@...bug:~#
> > 
> > The value for "dropped" increases steadily.  This particular box is on
> > a network with a lot of other stuff, so it will be constantly
> > receiving broadcasts of various kinds even when I am not trying to
> > address it directly.
> 
Based on the stats, the issue seems to be with the bridge than tg3. Do
you have any filters enabled on xenbr0 ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html