netdev - Re: [PATCH net-next] tcp: do not rearm rsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150408.202241.1719057759018638618.davem@davemloft.net>
Date:	Wed, 08 Apr 2015 20:22:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ycheng@...gle.com
Subject: Re: [PATCH net-next] tcp: do not rearm rsk_timer on FastOpen
 requests

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 08 Apr 2015 15:34:04 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> FastOpen requests are not like other regular request sockets.
> 
> They do not yet use rsk_timer : tcp_fastopen_queue_check()
> simply manually removes one expired request from fastopenq->rskq_rst
> list.
> 
> Therefore, tcp_check_req() must not call mod_timer_pending(),
> otherwise we crash because rsk_timer was not initialized.
> 
> Fixes: fa76ce7328b ("inet: get rid of central tcp/dccp listener timer")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html