netdev - Re: [patch net-next v3] tc: introduce OpenFlow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5527D49F.90201@mojatatu.com>
Date:	Fri, 10 Apr 2015 09:48:15 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Jiri Pirko <jiri@...nulli.us>,
	Daniel Borkmann <daniel@...earbox.net>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	tgraf@...g.ch, jesse@...ira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier

On 04/10/15 07:46, Jiri Pirko wrote:
> Fri, Apr 10, 2015 at 11:30:06AM CEST, daniel@...earbox.net wrote:
>> On 04/10/2015 11:12 AM, Jiri Pirko wrote:
>> ...

> I might be missing something, but to me, the codes of cls_flow and
> cls_openflow are very different. Merging cls_openflow with for example
> cls_fw makes similar sense to me.
>
> cls_flow is no match-action classifier. All skbs are hashed into classid
> of pre-defined range. You cannot speficy explicit action for match.
>
> On the other hand cls_openflow is match-action classifier (similar to
> for example bpf - might make more sense to me to merge it with bpf).
>
> What I say is, lets do things clearly, separate, not "overmerge" stuff.
>
> I will definitelly loose name "openflow" for my future submission to not
> to confuse people.
>

I think dropping the term "openflow" would be reasonable. I am not sure
if allowing for this to be part of cls_flow is reasonable.
I do think it makes sense to add another classifier that would do what
Dave was asking for. Such a classifier will have more advantages than
anything else imo since it will get most of the classification almost
for free.

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html