netdev - Re: [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5527DA3A.6030105@atmel.com>
Date:	Fri, 10 Apr 2015 16:12:10 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Wolfgang Steinwender <wsteinwender@....com>,
	<netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] net/macb: sqe_test_errors are TX errors, not
 RX errors

Le 10/04/2015 11:42, Wolfgang Steinwender a écrit :
> The statistics are grouped by TX and RX errors.
> The SQE Test Errors Register indicates problems with TX.
> 
> Signed-off-by: Wolfgang Steinwender <wsteinwender@....com>

seems okay:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

> ---
>  drivers/net/ethernet/cadence/macb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 448a323..9f53872 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1956,12 +1956,12 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
>  			    hwstat->rx_oversize_pkts +
>  			    hwstat->rx_jabbers +
>  			    hwstat->rx_undersize_pkts +
> -			    hwstat->sqe_test_errors +
>  			    hwstat->rx_length_mismatch);
>  	nstat->tx_errors = (hwstat->tx_late_cols +
>  			    hwstat->tx_excessive_cols +
>  			    hwstat->tx_underruns +
> -			    hwstat->tx_carrier_errors);
> +			    hwstat->tx_carrier_errors +
> +			    hwstat->sqe_test_errors);
>  	nstat->collisions = (hwstat->tx_single_cols +
>  			     hwstat->tx_multiple_cols +
>  			     hwstat->tx_excessive_cols);
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html