netdev - Re: [patch net-next v3] tc: introduce OpenFlow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5527981E.2040505@iogearbox.net>
Date:	Fri, 10 Apr 2015 11:30:06 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Jiri Pirko <jiri@...nulli.us>, David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, jhs@...atatu.com, tgraf@...g.ch,
	jesse@...ira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier

On 04/10/2015 11:12 AM, Jiri Pirko wrote:
...
>> However I am sure that I majorly object to having yet another flow
>> parsing engine.  Therefore, at least adjust this code to use our flow
>> dissector and datastructures.  Adjust the flow dissector to fit your
>> needs, if necessary.
>
> Yep, Thomas already suggested the merge. The thing is, cls_flow uses
> linked list for doing lookups. That is not scalable. in cls_openflow I
> use rhashtable. Using rhashtable in cls_flow would break the existing
> assumption that first inrested filter would be first hit.
>
> So that would lead into major dual code in cls_flow. So I believe that
> it is better to do it in separate cls_openflow (do one thing and do it
> right).

Would it be possible to 1) reuse the majority of the existing internal
cls_flow code as much as possible, integrate the remaining openflow
parts into it, and then 2) just register a 2nd classifier kind, a la ...

static struct tcf_proto_ops cls_flow_ht_ops __read_mostly = {
	.kind		= "flow-ht",
	.classify	= flow_classify_ht,
	.init		= flow_init,
	.destroy	= flow_destroy,
	.change		= flow_change,
	.delete		= flow_delete,
	.get		= flow_get,
	.dump		= flow_dump,
	.walk		= flow_walk,
	.owner		= THIS_MODULE,
};

... so you could do the non-linear rhashtable matching from there, but
without much duplication?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html