netdev - Re: [patch net-next v3] tc: introduce OpenFlow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150410.082359.964457460073432676.davem@davemloft.net>
Date:	Fri, 10 Apr 2015 08:23:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, jhs@...atatu.com, tgraf@...g.ch,
	jesse@...ira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 10 Apr 2015 11:12:03 +0200

> Thu, Apr 09, 2015 at 11:34:23PM CEST, davem@...emloft.net wrote:
>>However I am sure that I majorly object to having yet another flow
>>parsing engine.  Therefore, at least adjust this code to use our flow
>>dissector and datastructures.  Adjust the flow dissector to fit your
>>needs, if necessary.
> 
> Yep, Thomas already suggested the merge. The thing is, cls_flow uses
> linked list for doing lookups. That is not scalable. in cls_openflow I
> use rhashtable. Using rhashtable in cls_flow would break the existing
> assumption that first inrested filter would be first hit.

I'm talking about using net/core/flow_dissect.c's interfaces instead
of your by-hand header parsing.  This has nothing to do with cls_flow
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html