netdev - Re: [PATCH net-next] tcp: do not cache align timewait sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150412.211708.1005488304036582767.davem@davemloft.net>
Date:	Sun, 12 Apr 2015 21:17:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: do not cache align timewait sockets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 10 Apr 2015 06:07:18 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> With recent adoption of skc_cookie in struct sock_common,
> struct tcp_timewait_sock size increased from 192 to 200 bytes
> on 64bit arches. SLAB rounds then to 256 bytes.
> 
> It is time to drop SLAB_HWCACHE_ALIGN constraint for twsk_slab.
> 
> This saves about 12 MB of memory on typical configuration reaching
> 262144 timewait sockets, and has no noticeable impact on performance.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Looks reasonable, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html