netdev - Re: [PATCH v2 net-next] tcp/dccp: get rid of central timewait timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428938638.3834.9.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 13 Apr 2015 08:23:58 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] tcp/dccp: get rid of central timewait timer

On Sun, 2015-04-12 at 18:51 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>

> -void inet_twsk_schedule(struct inet_timewait_sock *tw,
> -		       struct inet_timewait_death_row *twdr,
> -		       const int timeo, const int timewait_len)
> +void inet_twsk_schedule(struct inet_timewait_sock *tw, const int timeo)
>  {
> -	struct hlist_head *list;
> -	int slot;
> -
>  	/* timeout := RTO * 3.5
>  	 *
>  	 * 3.5 = 1+2+0.5 to wait for two retransmits.
> @@ -367,115 +269,15 @@ void inet_twsk_schedule(struct inet_timewait_sock *tw,
>  	 * is greater than TS tick!) and detect old duplicates with help
>  	 * of PAWS.
>  	 */
> -	slot = (timeo + (1 << INET_TWDR_RECYCLE_TICK) - 1) >> INET_TWDR_RECYCLE_TICK;
>  
> -	spin_lock(&twdr->death_lock);
> -
> -	/* Unlink it, if it was scheduled */
> -	if (inet_twsk_del_dead_node(tw))
> -		twdr->tw_count--;
> -	else
> +	tw->tw_kill = timeo <= 4*HZ;	

I noticed extra spaces at the end of this line, I can either resend a v3
or let you remove this, thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html