netdev - Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150413.131259.1507649278753208323.davem@davemloft.net>
Date:	Mon, 13 Apr 2015 13:12:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	varun@...lsio.com
Cc:	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-rdma@...r.kernel.org, JBottomley@...allels.com,
	roland@...estorage.com, leedom@...lsio.com, anish@...lsio.com,
	hariprasad@...lsio.com, swise@...ngridcomputing.com,
	kxie@...lsio.com, praveenm@...lsio.com, kumaras@...lsio.com
Subject: Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

From: Varun Prakash <varun@...lsio.com>
Date: Mon, 13 Apr 2015 19:34:25 +0530

> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
> index 6c8a62e..f78d632 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
...
> + */
> +static inline unsigned int pages2ppods(unsigned int pages)
> +{
> +	return (pages + PPOD_PAGES - 1) / PPOD_PAGES +

Please do not ever use inline in foo.c file function definitions.  Let
the compiler decide on it's own.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html