netdev - Re: [PATCH net-next] tcp: fix bogus RTT for CC when retransmissions are acked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150413.135506.1156687955230440884.davem@davemloft.net>
Date:	Mon, 13 Apr 2015 13:55:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kennetkl@....uio.no
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix bogus RTT for CC when
 retransmissions are acked

From: Kenneth Klette Jonassen <kennetkl@....uio.no>
Date: Sat, 11 Apr 2015 02:17:49 +0200

> Since retransmitted segments are not used for RTT estimation, previously
> SACKed segments present in the rtx queue are used. This estimation can be
> several times larger than the actual RTT. When a cumulative ack covers both
> previously SACKed and retransmitted segments, CC may thus get a bogus RTT.
> 
> Such segments previously had an RTT estimation in tcp_sacktag_one(), so it
> seems reasonable to not reuse them in tcp_clean_rtx_queue() at all.
> 
> Afaik, this has had no effect on SRTT/RTO because of Karn's check.
> 
> Signed-off-by: Kenneth Klette Jonassen <kennetkl@....uio.no>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html