netdev - Re: [PATCH v4 net-next 2/2] tc: add 'needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7N1oPoZBgtF0WOa=aXveT4T=26yfL73Temdp+qWxkxfug@mail.gmail.com>
Date:	Mon, 13 Apr 2015 15:44:49 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Alexei Starovoitov <ast@...mgrid.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Thomas Graf <tgraf@...g.ch>, Jiri Pirko <jiri@...nulli.us>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 2/2] tc: add 'needs_l2' flag to ingress qdisc

On Fri, Apr 10, 2015 at 11:53 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
> On 04/11/2015 02:45 AM, Cong Wang wrote:
> ...
>>
>> The problem you try to solve is kernel's implementation problem,
>> users should not care, so we should make some effort to make ingress
>> align with egress, rather than making more differences.
>
>
> I guess you've followed the previous discussion up to this point,
> and are aware that we cannot break some users f.e. such as u32.

This is not hard to fix, e.g. pull it back in u32 for egress.

> There has been thought put into this and we went back and forth,
> if you have a better suggestion on how to get it resolved properly
> and generically, I'm all for it.

My suggestion is fairly simple: move skb_pull() out of eth_type_trans()
and move it to netif_receive_skb(), it apparently needs much more work
but it worth the effort. This would eliminate the skb_push() in mirred
and in ifb too, dev_forward_skb() would benefit too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html