netdev - Re: [PATCH v5 4/9] bgmac: simplify rx DMA error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150413232040.GA30799@electric-eye.fr.zoreil.com>
Date:	Tue, 14 Apr 2015 01:20:40 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Felix Fietkau <nbd@...nwrt.org>
Cc:	netdev@...r.kernel.org, zajec5@...il.com, hauke@...ke-m.de
Subject: Re: [PATCH v5 4/9] bgmac: simplify rx DMA error handling

Felix Fietkau <nbd@...nwrt.org> :
> Unmap the DMA buffer before checking it. If an error occurs, free the
> buffer and allocate a new one. If allocation or mapping fails, retry as
> long as there is NAPI poll budget left (count every attempt instead of
> every frame).

The driver is not supposed to use the NAPI budget this way.

If the driver can't reserve resources to handle the packet, it should
drop the data, keep everything in place for the hardware and move to the
next slot.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html