netdev - Re: [PATCH ethtool 1/5] ethtool-copy.h: sync with net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429023521.3211.49.camel@decadent.org.uk>
Date:	Tue, 14 Apr 2015 15:58:41 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	Eyal Grossman <eyalgr@...lanox.com>
Subject: Re: [PATCH ethtool 1/5] ethtool-copy.h: sync with net

On Tue, 2015-04-14 at 17:34 +0300, Amir Vadai wrote:
> On Sun, Apr 5, 2015 at 4:00 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> > On Sun, 2015-01-25 at 15:51 +0200, Amir Vadai wrote:
> >> From: Eyal Grossman <eyalgr@...lanox.com>
> 
> [...]
> 
> >
> > You've copied from include/uapi/linux/ethtool.h, which is not quite
> > right.  The include/uapi directory contains definitions shared with
> > userland, but the headers still need some processing (like removing the
> > _UAPI prefix from header guards).  You should use 'make headers_install'
> > to generate the userland version in usr/include/linux/ethtool.h.
> Sorry, didn't know.
> 
> > Anyway, I've done that myself based on today's net tree.
> Is it in your git [1] ? Because I couldn't find the updated version there.
> 
> [1] - git://git.kernel.org/pub/scm/network/ethtool/ethtool.git

Sorry, it is now.

Ben.

-- 
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)