netdev - Re: [Patch net-next] fou: avoid missing unlock in failure path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429030869.7346.41.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 14 Apr 2015 10:01:09 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org, Tom Herbert <tom@...bertland.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [Patch net-next] fou: avoid missing unlock in failure path

On Tue, 2015-04-14 at 09:32 -0700, Cong Wang wrote:
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  net/ipv4/fou.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
> index 2637102..1df3399 100644
> --- a/net/ipv4/fou.c
> +++ b/net/ipv4/fou.c
> @@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
>  				    cb->nlh->nlmsg_seq, NLM_F_MULTI,
>  				    skb, FOU_CMD_GET);
>  		if (ret)
> -			goto done;
> +			break;
>  	}
>  	mutex_unlock(&fn->fou_lock);
>  
> -done:
>  	cb->args[0] = idx;
>  	return skb->len;
>  }

When was this bug added ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html