netdev - Re: [PATCH net-next V2 12/12] net/mlx5: Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2015 14:51:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, yevgenyp@...lanox.com, saeedm@...lanox.com,
	ogerlitz@...lanox.com, achiad@...lanox.com, idos@...lanox.com,
	talal@...lanox.com
Subject: Re: [PATCH net-next V2 12/12] net/mlx5: Ethernet driver

From: Amir Vadai <amirv@...lanox.com>
Date: Tue, 14 Apr 2015 11:20:35 +0300

> Signed-off-by: Amir Vadai <amirv@...lanox.com>

What does "Ethernet driver" mean?

Are you adding a new ethernet driver?  If so, what is it for and how
does it interact with the existing mlx5 driver?

It looks to me like you are adding a lot of code and objects to the
existing mlx5 module.  An incredible amount, in fact.  This seems very
suboptimal especially for users of the existing mlx5 chips.

You haven't discussed this, what design decisions made you decide
in the end to do it this way, etc.

You absolutely have to say something other than "Ethernet driver"
in this commit message, I expect several paragraphs of details
and the hows and whys of the change as it is a non-trivial amount
of code being added here.

I still consider this patch series not ready yet, and the merge
window is open thus closing the net-next tree.

You will therefore need to wait until the net-next tree opens
again before submitting this series again.

THanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html