netdev - Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414192316.GB27750@mtldesk30>
Date:	Tue, 14 Apr 2015 22:23:16 +0300
From:	Eli Cohen <eli@....mellanox.co.il>
To:	Honggang Li <honli@...hat.com>
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next v2] mlx5: wrong page mask if
 CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote:
> @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr)
>  static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id)
>  {
>  	struct page *page;
> -	u64 addr;
> +	u64 addr = 0;
>  	int err;
>  	int nid = dev_to_node(&dev->pdev->dev);
>  

I really don't see any reason why you need to set addr to 0. Can you
please explain this?
Other than that the patch is ok.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html