netdev - Re: [PATCH net-next V1 00/11] net/mlx5: ConnectX-4 100G Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150413.221522.162480193486167425.davem@davemloft.net>
Date:	Mon, 13 Apr 2015 22:15:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, yevgenyp@...lanox.com, saeedm@...lanox.com,
	ogerlitz@...lanox.com, achiad@...lanox.com, idos@...lanox.com,
	talal@...lanox.com
Subject: Re: [PATCH net-next V1 00/11] net/mlx5: ConnectX-4 100G Ethernet
 driver

From: Amir Vadai <amirv@...lanox.com>
Date: Mon, 13 Apr 2015 14:44:50 +0300

> - Removed V0 Patch 1/11 ("net/mlx5_core: Virtually extend work/completion queue
>   buffers by one page") due to misuse of DMA API. Thanks Dave.

I don't know how stupid you think I am....

You may have removed the patch that did the refactoring, but the
completely broken code misusing the DMA API is still there in this
driver.

I said I want you to fix this fundamental problem with your driver
before making major changes like this series to it.

And I really meant it.

Don't try to side step the issue in the way that you did here.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html