netdev - Re: [PATCH resend] Renesas Ethernet AVB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552CE890.3040103@cogentembedded.com>
Date:	Tue, 14 Apr 2015 13:14:40 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org,
	Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>,
	masaru.nagai.vx@...esas.com
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver

Hello.

On 4/14/2015 8:27 AM, Richard Cochran wrote:

>>>> This is a bit hacky.  Can't your driver make sure that the HW is ready?

>>>     Will look into this. Perhaps it's a remainder from when the PTP driver was
>>> separate...

>>     No, we enter this mode upon closing the Ethernet device and when
>> the ring DMA sizes are changed. Seems unavoidable...

>>>>> +    if (ravb_read(priv->ndev, CSR) & CSR_OPS_CONFIG)
>>>>> +        return true;
>>>>> +    else
>>>>> +        return false;

> It is surely avoidable.  The driver knows (or should know) whether or
> not the hardware has been configured or not.

    So you only want to avoid the register read here?

> Thanks,
> Richard

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html