lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2015 17:25:40 -0400 (EDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: Yuval.Mintz@...gic.com, netdev@...r.kernel.org, bind@...s.net, peter@...leysoftware.com, Ariel.Elior@...gic.com, willemb@...gle.com Subject: Re: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll From: Eric Dumazet <eric.dumazet@...il.com> Date: Tue, 14 Apr 2015 18:45:00 -0700 > From: Eric Dumazet <edumazet@...gle.com> > > Commit 9a2620c877454 ("bnx2x: prevent WARN during driver unload") > switched the napi/busy_lock locking mechanism from spin_lock() into > spin_lock_bh(), breaking inter-operability with netconsole, as netpoll > disables interrupts prior to calling our napi mechanism. > > This switches the driver into using atomic assignments instead of the > spinlock mechanisms previously employed. > > Based on initial patch from Yuval Mintz & Ariel Elior > > I basically added softirq starvation avoidance, and mixture > of atomic operations, plain writes and barriers. > > Note this slightly reduces the overhead for this driver when no > busy_poll sockets are in use. > > Fixes: 9a2620c877454 ("bnx2x: prevent WARN during driver unload") > Signed-off-by: Eric Dumazet <edumazet@...gle.com> Applied and queued up for -stable, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists