netdev - RE: [PATCH 16/17] get rid of the size argument of sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB1E7FD@AcuExch.aculab.com>
Date:	Wed, 15 Apr 2015 08:37:01 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'David Miller' <davem@...emloft.net>,
	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 16/17] get rid of the size argument of sock_sendmsg()

From: David Miller
> Sent: 14 April 2015 18:56
> > On Tue, Apr 14, 2015 at 04:25:24PM +0000, David Laight wrote:
> >> From: Al Viro
> >> > Sent: 11 April 2015 22:18
> >> > it's equal to iov_iter_count(&msg->msg_iter) in all cases
> >>
> >> I don't know whether this is guaranteed for iov[] that come from
> >> userspace.
> >>
> >> In any case iov_iter_count() is non-trivial and you don't
> >> really want to call it when unnecessary.
> >
> > Really?
> >
> > static inline size_t iov_iter_count(struct iov_iter *i)
> > {
> >         return i->count;
> > }
> 
> This just made my day.

I hate accessor functions

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html