netdev - Re: [net-next 03/14] i40e: Add support to program FDir SB rules for VF from PF through ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2015 11:58:19 +0300
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Anjali Singhai Jain <anjali.singhai@...el.com>,
	Ben Hutchings <ben@...adent.org.uk>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	Matan Barak <matanb@...lanox.com>
Subject: Re: [net-next 03/14] i40e: Add support to program FDir SB rules for
 VF from PF through ethtool

On Wed, Apr 15, 2015 at 7:51 AM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:
> From: Anjali Singhai Jain <anjali.singhai@...el.com>

> With this patch we can now add Flow director Sideband rules for a VF from
> it's PF. Here is an example on how it can be done when VF id = 5 and
> queue = 2:
>
> "ethtool -N ethx flow-type udp4 src-ip x.x.x.x dst-ip y.y.y.y src-port p1 dst-port p2 action 2 user-def 5"
>
> User-def specifies VF id and action specifies queue.

Hi Jeff,

We're too eager to have support for PF controlled ACL / over-ruling VF traffic.

I don't think the way to go here is just go an use the user-defined
"data" field of struct ethtool_flow_ext to represent a VF -- since VF
is well defined multiple vendor supported construct. At least in the
command line would be better to see "vf 5" and not "user-def 5" -- and
maybe also down into the user-kernel API somehow enhance the ethtool
flow related structures such that VF ID is specified?

Or.


> Change-ID: Ib37d6dff3823a4d85caffde638473891c38c2b89
> Signed-off-by: Anjali Singhai Jain <anjali.singhai@...el.com>
> Tested-by: Jim Young <james.m.young@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index c848b18..7d60587 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -1914,6 +1914,16 @@ static int i40e_get_ethtool_fdir_entry(struct i40e_pf *pf,
>         else
>                 fsp->ring_cookie = rule->q_index;
>
> +       if (rule->dest_vsi != pf->vsi[pf->lan_vsi]->id) {
> +               struct i40e_vsi *vsi;
> +
> +               vsi = i40e_find_vsi_from_id(pf, rule->dest_vsi);
> +               if (vsi && vsi->type == I40E_VSI_SRIOV) {
> +                       fsp->h_ext.data[1] = htonl(vsi->vf_id);
> +                       fsp->m_ext.data[1] = htonl(0x1);
> +               }
> +       }
> +
>         return 0;
>  }
>
> @@ -2207,6 +2217,7 @@ static int i40e_add_fdir_ethtool(struct i40e_vsi *vsi,
>         struct i40e_fdir_filter *input;
>         struct i40e_pf *pf;
>         int ret = -EINVAL;
> +       u16 vf_id;
>
>         if (!vsi)
>                 return -EINVAL;
> @@ -2267,7 +2278,22 @@ static int i40e_add_fdir_ethtool(struct i40e_vsi *vsi,
>         input->dst_ip[0] = fsp->h_u.tcp_ip4_spec.ip4src;
>         input->src_ip[0] = fsp->h_u.tcp_ip4_spec.ip4dst;
>
> +       if (ntohl(fsp->m_ext.data[1])) {
> +               if (ntohl(fsp->h_ext.data[1]) >= pf->num_alloc_vfs) {
> +                       netif_info(pf, drv, vsi->netdev, "Invalid VF id\n");
> +                       goto free_input;
> +               }
> +               vf_id = ntohl(fsp->h_ext.data[1]);
> +               /* Find vsi id from vf id and override dest vsi */
> +               input->dest_vsi = pf->vf[vf_id].lan_vsi_id;
> +               if (input->q_index >= pf->vf[vf_id].num_queue_pairs) {
> +                       netif_info(pf, drv, vsi->netdev, "Invalid queue id\n");
> +                       goto free_input;
> +               }
> +       }
> +
>         ret = i40e_add_del_fdir(vsi, input, true);
> +free_input:
>         if (ret)
>                 kfree(input);
>         else
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html