netdev - Re: [PATCH 16/17] get rid of the size argument of sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429092946.7346.74.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 15 Apr 2015 03:15:46 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	'David Miller' <davem@...emloft.net>,
	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 16/17] get rid of the size argument of sock_sendmsg()

On Wed, 2015-04-15 at 08:37 +0000, David Laight wrote:
> From: David Miller
> > Sent: 14 April 2015 18:56
> > > On Tue, Apr 14, 2015 at 04:25:24PM +0000, David Laight wrote:
> > >> From: Al Viro
> > >> > Sent: 11 April 2015 22:18
> > >> > it's equal to iov_iter_count(&msg->msg_iter) in all cases
> > >>
> > >> I don't know whether this is guaranteed for iov[] that come from
> > >> userspace.
> > >>
> > >> In any case iov_iter_count() is non-trivial and you don't
> > >> really want to call it when unnecessary.
> > >
> > > Really?
> > >
> > > static inline size_t iov_iter_count(struct iov_iter *i)
> > > {
> > >         return i->count;
> > > }
> > 
> > This just made my day.
> 
> I hate accessor functions

It is quite clear you do not really tweak linux code, do you ?

Typical linux developers love them when they want to add in accessor a
debugging facility or logic.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html