netdev - Re: [PATCH net-next 3/6] net: hip04: Solve the problem of the skb memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2443005.XhuHWvJbTU@wuerfel>
Date:	Wed, 15 Apr 2015 16:17:31 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	davem@...emloft.net, grant.likely@...aro.org,
	sergei.shtylyov@...entembedded.com,
	linux-arm-kernel@...ts.infradead.org, eric.dumazet@...il.com,
	zhangfei.gao@...aro.org, joe@...ches.com, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux@....linux.org.uk
Subject: Re: [PATCH net-next 3/6] net: hip04: Solve the problem of the skb memory allocation failure

On Wednesday 15 April 2015 20:30:05 Ding Tianhong wrote:
> The driver will alloc some skb buffer for hareware queue, but without
> considering the case of memory allocation failure, when memory is low,
> the skb may be null and panic the system, so break the loop when skb is
> null and try to alloc the memory again to fix this problem.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Zhangfei Gao <zhangfei.gao@...aro.org>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Joe Perches <joe@...ches.com>
> 

Looks reasonable to me, though I haven't done a deep analysis
to see if there are remaining problems in this area.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html