netdev - Re: [PATCH] net: dsa: mv88e6xxx: Add missing initialization in mv88e6xxx_set_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150416.153423.2060745319495574933.davem@davemloft.net>
Date:	Thu, 16 Apr 2015 15:34:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	linux@...ck-us.net, andrew@...n.ch, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add missing initialization in
 mv88e6xxx_set_port_state()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu, 16 Apr 2015 20:49:14 +0200

> drivers/net/dsa/mv88e6xxx.c: In function ‘mv88e6xxx_set_port_state’:
> drivers/net/dsa/mv88e6xxx.c:905: warning: ‘ret’ may be used uninitialized in this function
> 
> If oldstate == state, mv88e6xxx_set_port_state() will return an
> uninitialized value. Pre-initialize ret to zero to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Indeed, applied, thanks Geert.