netdev - Re: [net-next 03/14] i40e: Add support to program FDir SB rules for VF from PF through ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1429148556.2638.72.camel@jtkirshe-mobl>
Date:	Wed, 15 Apr 2015 18:42:36 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Or Gerlitz <gerlitz.or@...il.com>,
	Anjali Singhai Jain <anjali.singhai@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	Matan Barak <matanb@...lanox.com>
Subject: Re: [net-next 03/14] i40e: Add support to program FDir SB rules for
 VF from PF through ethtool

On Wed, 2015-04-15 at 11:58 +0300, Or Gerlitz wrote:
> On Wed, Apr 15, 2015 at 7:51 AM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: Anjali Singhai Jain <anjali.singhai@...el.com>
> 
> > With this patch we can now add Flow director Sideband rules for a VF
> from
> > it's PF. Here is an example on how it can be done when VF id = 5 and
> > queue = 2:
> >
> > "ethtool -N ethx flow-type udp4 src-ip x.x.x.x dst-ip y.y.y.y
> src-port p1 dst-port p2 action 2 user-def 5"
> >
> > User-def specifies VF id and action specifies queue.
> 
> Hi Jeff,
> 
> We're too eager to have support for PF controlled ACL / over-ruling VF
> traffic.
> 
> I don't think the way to go here is just go an use the user-defined
> "data" field of struct ethtool_flow_ext to represent a VF -- since VF
> is well defined multiple vendor supported construct. At least in the
> command line would be better to see "vf 5" and not "user-def 5" -- and
> maybe also down into the user-kernel API somehow enhance the ethtool
> flow related structures such that VF ID is specified?

Thanks for the feedback Or, I will work with Anajali and Jesse to get
your suggestions implemented in follow-on patches.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)