netdev - Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552FB062.5090307@roeck-us.net>
Date:	Thu, 16 Apr 2015 05:51:46 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Andrew Lunn <andrew@...n.ch>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/16/2015 05:37 AM, Andrew Lunn wrote:
> On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote:
>> Return correct error code if _mv88e6xxx_reg_read returns an error.
>>
>> Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support")
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> Hi Guenter
>
> Good catch. I'm surprised there is no compiler warning, possibly used
> before set.
>
There was, actually. No idea how I missed that. Fengguang's build bots caught it.

> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>
Thanks!

Guenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html