netdev - Re: [v3] skbuff: Do not scrub skb mark within the same name space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150416.142124.1721494984301782904.davem@davemloft.net>
Date:	Thu, 16 Apr 2015 14:21:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	herbert@...dor.apana.org.au, nicolas.dichtel@...nd.com,
	netdev@...r.kernel.org, ebiederm@...ssion.com, jmorris@...ei.org,
	linux-security-module@...r.kernel.org
Subject: Re: [v3] skbuff: Do not scrub skb mark within the same name space

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 16 Apr 2015 09:33:35 +0100

> On 04/16/15 at 09:03am, Herbert Xu wrote:
>> The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels:
>> harmonize cleanup done on skb on rx path") broke anyone trying to
>> use netfilter marking across IPv4 tunnels.  While most of the
>> fields that are cleared by skb_scrub_packet don't matter, the
>> netfilter mark must be preserved.
>> 
>> This patch rearranges skb_scrub_packet to preserve the mark field.
>> 
>> Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path")
>> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Acked-by: Thomas Graf <tgraf@...g.ch>
> 
> We should also add a flag to veth which expclitly allows to preserve
> the mark into the namespace.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html