netdev - Re: act_mirred: Fix bogus header when redirecting from VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150417013401.GA4335@Alexeis-MacBook-Pro.local>
Date:	Thu, 16 Apr 2015 18:34:02 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	netdev@...r.kernel.org, jamal <hadi@...erus.ca>
Subject: Re: act_mirred: Fix bogus header when redirecting from VLAN

On Fri, Apr 17, 2015 at 09:02:16AM +0800, Herbert Xu wrote:
> @@ -105,7 +105,7 @@ static void ri_tasklet(unsigned long dev)
>  		if (from & AT_EGRESS) {
>  			dev_queue_xmit(skb);
>  		} else if (from & AT_INGRESS) {
> -			skb_pull(skb, skb->dev->hard_header_len);
> +			skb_pull(skb, _dev->hard_header_len);
...
>  	if (!(at & AT_EGRESS)) {
>  		if (m->tcfm_ok_push)
> -			skb_push(skb2, skb2->dev->hard_header_len);
> +			skb_push(skb2, dev->hard_header_len);

seems the cleaner fix will be to push skb->mac_len instead?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html