netdev - Re: [PATCH net] tcp: tcp_get_info() should fetch socket fields once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150417.132845.1469377605486721196.davem@davemloft.net>
Date:	Fri, 17 Apr 2015 13:28:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: tcp_get_info() should fetch socket fields once

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Apr 2015 16:12:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> tcp_get_info() can be called without holding socket lock,
> so any socket fields can change under us.
> 
> Use READ_ONCE() to fetch sk_pacing_rate and sk_max_pacing_rate
> 
> Fixes: 977cb0ecf82e ("tcp: add pacing_rate information into tcp_info")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> David, I do not think this needs stable backport, this is a quite
> minor bug. I've added the 'Fixes' tag for reference only.

Ok, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html