netdev - [PATCH] etherdevice: Add ether_addr_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1429479577-3977-1-git-send-email-mateusz.kulikowski@gmail.com>
Date:	Sun, 19 Apr 2015 23:39:37 +0200
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	davem@...emloft.net
Cc:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>, joe@...ches.com,
	dan.carpenter@...cle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] etherdevice: Add ether_addr_copy_unaligned

Some drivers require copying unaligned ethernet addresses.
Using memcpy() causes checkpatch warnings and may cause
regressions (someone will "fix" alignment of packed structure)

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
---
 include/linux/etherdevice.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 606563e..681874f 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -244,6 +244,22 @@ static inline void ether_addr_copy(u8 *dst, const u8 *src)
 }
 
 /**
+ * ether_addr_copy_unaligned - Copy unaligned Ethernet address
+ * @dst: Pointer to a six-byte array Ethernet address destination
+ * @src: Pointer to a six-byte array Ethernet address source
+ *
+ * Please note: Use only when any Ethernet address may not be u16 aligned.
+ */
+static inline void ether_addr_copy_unaligned(u8 *dst, const u8 *src)
+{
+#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
+	ether_addr_copy(dst, src);
+#else
+	memcpy(dst, src, ETH_ALEN);
+#endif
+}
+
+/**
  * eth_hw_addr_inherit - Copy dev_addr from another net_device
  * @dst: pointer to net_device to copy dev_addr to
  * @src: pointer to net_device to copy dev_addr from
-- 
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html