netdev - Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5534B5E2.6060804@mellanox.com>
Date:	Mon, 20 Apr 2015 11:16:34 +0300
From:	Haggai Eran <haggaie@...lanox.com>
To:	Doug Ledford <dledford@...hat.com>,
	Roland Dreier <roland@...nel.org>
CC:	David Miller <davem@...emloft.net>, <erezsh@...lanox.com>,
	<netdev@...r.kernel.org>, <nicolas.dichtel@...nd.com>,
	<linux-rdma@...r.kernel.org>, <honli@...hat.com>
Subject: Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

On 17/04/2015 22:21, David Miller wrote:
> From: Erez Shitrit <erezsh@...lanox.com>
> Date: Thu, 16 Apr 2015 16:34:34 +0300
> 
>> Currently, iflink of the parent interface was always accessed, even 
>> when interface didn't have a parent and hence we crashed there.
>>
>> Handle the interface types properly: for a child interface, return
>> the ifindex of the parent, for parent interface, return its ifindex.
>>
>> For child devices, make sure to set the parent pointer prior to
>> invoking register_netdevice(), this allows the new ndo to be called
>> by the stack immediately after the child device is registered.
>>
>> Fixes: 5aa7add8f14b ('infiniband/ipoib: implement ndo_get_iflink')
>> Reported-by: Honggang Li <honli@...hat.com>
>> Signed-off-by: Erez Shitrit <erezsh@...lanox.com>
>> Signed-off-by: Honggang Li <honli@...hat.com>
> 
> Applied, thanks.

Doug, Roland,

You might want to include this patch in your for-next / for-4.1 trees,
or merge net-next again. Currently they contain the issue it fixes, and
it can prevent some systems with IPoIB from booting.

Regards,
Haggai

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html