netdev - Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2015 11:37:02 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Haggai Eran <haggaie@...lanox.com>,
	Roland Dreier <roland@...nel.org>,
	David Miller <davem@...emloft.net>,
	Erez Shitrit <erezsh@...lanox.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Honggang Li <honli@...hat.com>
Subject: Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

On Mon, 2015-04-20 at 12:21 +0300, Or Gerlitz wrote:
> On Mon, Apr 20, 2015 at 11:16 AM, Haggai Eran <haggaie@...lanox.com> wrote:
> > On 17/04/2015 22:21, David Miller wrote:
> >> From: Erez Shitrit <erezsh@...lanox.com>
> >> Date: Thu, 16 Apr 2015 16:34:34 +0300
> >>
> >>> Currently, iflink of the parent interface was always accessed, even
> >>> when interface didn't have a parent and hence we crashed there.
> >>>
> >>> Handle the interface types properly: for a child interface, return
> >>> the ifindex of the parent, for parent interface, return its ifindex.
> >>>
> >>> For child devices, make sure to set the parent pointer prior to
> >>> invoking register_netdevice(), this allows the new ndo to be called
> >>> by the stack immediately after the child device is registered.
> >>>
> >>> Fixes: 5aa7add8f14b ('infiniband/ipoib: implement ndo_get_iflink')
> >>> Reported-by: Honggang Li <honli@...hat.com>
> >>> Signed-off-by: Erez Shitrit <erezsh@...lanox.com>
> >>> Signed-off-by: Honggang Li <honli@...hat.com>
> >>
> >> Applied, thanks.
> >
> > Doug, Roland,
> > You might want to include this patch in your for-next / for-4.1 trees,
> > or merge net-next again. Currently they contain the issue it fixes, and
> > it can prevent some systems with IPoIB from booting.
> 
> Haggai,
> 
> 
> It's upstream by now, pull Linus tree.
> 
> Or.

Right, it already went via net-next.  I skipped it because of that.

-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)