netdev - Re: [RFC PATCH 04/10] ipv6: Only create RTF_CACHE routes after encountering pmtu exception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150420.142841.583067282489152059.davem@davemloft.net>
Date:	Mon, 20 Apr 2015 14:28:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kafai@...com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org,
	kernel-team@...com
Subject: Re: [RFC PATCH 04/10] ipv6: Only create RTF_CACHE routes after
 encountering pmtu exception

From: Martin KaFai Lau <kafai@...com>
Date: Fri, 10 Apr 2015 18:54:07 -0700

> +	if (!(rt6->rt6i_flags & RTF_CACHE) &&
> +	    (!(rt6->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)) ||
> +	     !(rt6->dst.flags & DST_HOST))) {

These big convoluted tests are tiring to read over and over again.

At the very least, "(rt6->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)"
deserves to be a descriptively named inline function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html