netdev - RE: [Intel-wired-lan] [PATCH] e1000e: Do not allow CRC stripping to be disabled on 82579 w/ jumbo frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B78DA68B4@ORSMSX101.amr.corp.intel.com>
Date:	Tue, 21 Apr 2015 03:12:05 +0000
From:	"Brown, Aaron F" <aaron.f.brown@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	Alexander Duyck <alexander.h.duyck@...hat.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] e1000e: Do not allow CRC stripping to
 be disabled on 82579 w/ jumbo frames

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...ts.osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Wednesday, April 08, 2015 7:58 PM
> To: Alexander Duyck
> Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Do not allow CRC stripping
> to be disabled on 82579 w/ jumbo frames
> 
> On Wed, 2015-04-08 at 18:37 -0700, Alexander Duyck wrote:
> > The driver wasn't allowing jumbo frames to be enabled when CRC
> > stripping
> > was disabled, however it was allowing CRC stripping to be disabled
> > while
> > jumbo frames were enabled.  This fixes that by making it so that the
> > NETIF_F_RXFCS flag cannot be set when jumbo frames are enabled on
> > 82579 and
> > newer parts.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> > ---
> >  drivers/net/ethernet/intel/e1000e/netdev.c |   14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> 
> Thanks Alex, I will add your patch to my queue.

Tested-by: Aaron Brown <aaron.f.brown@...el.com>

> --
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
> dev-queue