netdev - Re: [PATCH 1/1] v2: Driver: hv: netvsc: call dump_rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150421.174540.2189432113402169667.davem@davemloft.net>
Date:	Tue, 21 Apr 2015 17:45:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sixiao@...rosoft.com
Cc:	kys@...rosoft.com, haiyangz@...rosoft.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] v2: Driver: hv: netvsc: call dump_rndis_message()
 only in netvsc debug mode

From: sixiao@...rosoft.com
Date: Tue, 21 Apr 2015 14:43:55 -0700

> From: Simon Xiao <sixiao@...rosoft.com>
> 
> Signed-off-by: Simon Xiao <sixiao@...rosoft.com>

This commit message is lacking an explanation why you want to do
what you are doing.

Also, we have an existing mechanism to control network device driver
debug logging output, please use it rather than invent your own
facility.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html