netdev - Re: [PATCH v2 00/11] Add network namespace support in the RDMA-CM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5535EFE9.3000106@mellanox.com>
Date:	Tue, 21 Apr 2015 09:36:25 +0300
From:	Haggai Eran <haggaie@...lanox.com>
To:	Steve Wise <swise@...ngridcomputing.com>,
	Doug Ledford <dledford@...hat.com>,
	Roland Dreier <roland@...nel.org>
CC:	Sean Hefty <sean.hefty@...el.com>, <linux-rdma@...r.kernel.org>,
	<netdev@...r.kernel.org>, Liran Liss <liranl@...lanox.com>,
	Guy Shapiro <guysh@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Yotam Kenneth <yotamke@...lanox.com>
Subject: Re: [PATCH v2 00/11] Add network namespace support in the RDMA-CM

On 20/04/2015 17:53, Steve Wise wrote:
> 
> Hey Haggai,
> 
> Did you check for changes needed in drivers/infiniband/core/iwcm.c? 

We focused on namespace support for InfiniBand alone in this series. We
didn't handle iWARP, nor did we implement support for RoCE or other
transports.

> I notice that it uses init_net here:
> 
> static int __init iw_cm_init(void)
> {
>         iwcm_wq = create_singlethread_workqueue("iw_cm_wq");
>         if (!iwcm_wq)
>                 return -ENOMEM;
> 
>         iwcm_ctl_table_hdr = register_net_sysctl(&init_net, "net/iw_cm",
>                                                  iwcm_ctl_table);
>         if (!iwcm_ctl_table_hdr) {
>                 pr_err("iw_cm: couldn't register sysctl paths\n");
>                 destroy_workqueue(iwcm_wq);
>                 return -ENOMEM;
>         }
> 
>         return 0;
> }
> 

I see the only thing in the iWARP sysctl registered here is the default
backlog. If you want to control this parameter per namespace, we could
store it per network namespace, and add a namespace parameter to
iw_cm_listen. I'm not sure how important this is though.

Haggai
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html