netdev - Re: [PATCH 0/3] mpls: ABI changes for security and correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150421.221216.1827780895297926700.davem@davemloft.net>
Date:	Tue, 21 Apr 2015 22:12:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	rshearma@...cade.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] mpls: ABI changes for security and correctness

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Tue, 21 Apr 2015 19:29:42 -0500

> Robert Shearman <rshearma@...cade.com> writes:
> 
>> These changes make mpls not be enabled by default on all
>> interfaces when in use for security, along with ensuring that a label
>> not valid as an outgoing label can be added in mpls routes.
>>
>> This series contains three ABI/behaviour-affecting changes which have
>> been split out from "[PATCH net-next v4 0/6] mpls: Behaviour-changing
>> improvements" without any further modification. These changes need to
>> be considered for 4.1 otherwise we'll be stuck with the current
>> behaviour/ABI forever.
> 
> I don't like the difference in default between loopback and everything
> else.  That just seems like an extra arbitrary rule.
> 
> Otherwise:
> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> 
> Not that I expect Dave Miller is taking patches during the merge window.

Eric, you say you disagree with the loopback vs. everything else
behavior, yet you're ACK'ing this.

Please don't say something like that because it is confusing and
I can't tell what you want me to do.

If you're willing to accept the series as is, say is: "Even though
I disagree with X, I'm ok with this series for now."

If you want changes before the series gets applied: "I want X
changed to Y, and with that I give my ACK."

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html