netdev - Re: [PATCH] xfrm: fix the xfrm_policy/state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150422075755.GA9163@gondor.apana.org.au>
Date:	Wed, 22 Apr 2015 15:57:55 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: [PATCH] xfrm: fix the xfrm_policy/state_walk

On Wed, Apr 22, 2015 at 03:53:34PM +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> If the walk from input is not empty, the following loop should start from
> the walk->next, since walk is list header, and the last policy in previours
> loop is connected walk tailor by list_move_tail()
> 
> Fixes: 12a169e7d8f(ipsec: Put dumpers on the dump list)
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

This is not a bug fix but an optimisation.  The walker entries are
all marked as dead and will be skipped by the loop.

However, I don't see anything wrong with this optimisation.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html