netdev - Re: [PATCH net-next] be2net: log link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5537A0AA.50407@redhat.com>
Date:	Wed, 22 Apr 2015 15:22:50 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	netdev@...r.kernel.org, Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>
Subject: Re: [PATCH net-next] be2net: log link status

On 04/22/2015 03:10 PM, Joe Perches wrote:
> On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
>> The driver unlike other drivers does not log link state changes.
> []
>> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> []
>> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>>   		netif_carrier_on(netdev);
>>   	else
>>   		netif_carrier_off(netdev);
>> +
>> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>>   }
>
> If this is valuable, it's also valuable to emit the
> link speed/duplex states like most other drivers.
>
Duplex state is not much valuable as for be2net link-up means 
full-duplex and link-down means unknown-duplex.
But link speed could be valuable. Will send v2.

Ivan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html