netdev - Re: [PATCH net-next v2] be2net: log link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5537AD73.5070401@redhat.com>
Date:	Wed, 22 Apr 2015 16:17:23 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	netdev@...r.kernel.org, Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>
Subject: Re: [PATCH net-next v2] be2net: log link status

On 04/22/2015 04:07 PM, Joe Perches wrote:
> On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>> >The driver unlike other drivers does not log link state changes.
> Why add all the speed stuff, why not add a query instead?
>
> I think it'd be simpler to add a line like:
> 	status = be_cmd_link_status_query(adapter, &speed, &status, 0);
> before emitting speed/link_status
The func be_link_status_update() is also called from 
be_async_link_state_process() and I'm not sure if it is possible to call 
be_cmd_link_status_query() from its context.

Ivan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html