netdev - Re: [PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sibsktsg.fsf@x220.int.ebiederm.org>
Date:	Wed, 22 Apr 2015 11:32:47 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Robert Shearman <rshearma@...cade.com>
Cc:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label

Robert Shearman <rshearma@...cade.com> writes:

> The reserved implicit-NULL label isn't allowed to appear in the label
> stack for packets, so make it an error for the control plane to
> specify it as an outgoing label.

Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>

>
> Suggested-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> Signed-off-by: Robert Shearman <rshearma@...cade.com>
> ---
>  net/mpls/af_mpls.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 9fdd94cba83e..954810c76a86 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -646,6 +646,15 @@ int nla_get_labels(const struct nlattr *nla,
>  		if ((dec.bos != bos) || dec.ttl || dec.tc)
>  			return -EINVAL;
>  
> +		switch (dec.label) {
> +		case LABEL_IMPLICIT_NULL:
> +			/* RFC3032: This is a label that an LSR may
> +			 * assign and distribute, but which never
> +			 * actually appears in the encapsulation.
> +			 */
> +			return -EINVAL;
> +		}
> +
>  		label[i] = dec.label;
>  	}
>  	*labels = nla_labels;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html