netdev - Re: [RFC 1/3] tc: fix return values of ingress qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150423084612.GH21799@casper.infradead.org>
Date:	Thu, 23 Apr 2015 09:46:12 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Alexei Starovoitov <ast@...mgrid.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 1/3] tc: fix return values of ingress qdisc

On 04/22/15 at 04:29pm, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 3:04 PM, Alexei Starovoitov <ast@...mgrid.com> wrote:
> > On 4/21/15 9:59 PM, Cong Wang wrote:
> >>
> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov <ast@...mgrid.com>
> >> wrote:
> >>>
> >>> ingress qdisc should return NET_XMIT_* values just like all other qdiscs.
> >>>
> >>
> >> XMIT already means egress...
> >
> >
> > may be then it should be renamed as well.
> > from include/linux/netdevice.h:
> > /* qdisc ->enqueue() return codes. */
> > #define NET_XMIT_SUCCESS        0x00
> > ...
> >
> > the point is that qdisc->enqeue() must return NET_XMIT_* values.
> > ingress qdisc is violating this and therefore should be fixed.
> 
> XMIT is non-sense for ingress, you really need to pick another
> name for it if TC_ACT_OK isn't okay for you (it is okay for me).

You transmit into a qdisc. If that terminology doesn't suit
you then rename it to NET_QUEUE_* but moving away from returning
TC_ACT_* is definitely the right thing to do here.
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html