netdev - Re: [RFC 2/3] tc: deprecate TC_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7PoJjcwiTBJC5BLSRTeMprbNkuojAyOHjqMw46+L=mAnA@mail.gmail.com>
Date:	Thu, 23 Apr 2015 11:30:33 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Alexei Starovoitov <ast@...mgrid.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

On Thu, Apr 23, 2015 at 11:21 AM, Daniel Borkmann <daniel@...earbox.net> wrote:
> On 04/23/2015 08:12 PM, Cong Wang wrote:
>>
>> On Wed, Apr 22, 2015 at 7:46 PM, Alexei Starovoitov <ast@...mgrid.com>
>> wrote:
>
> ...
>>>
>>> TC_ACT_QUEUED cannot be removed.
>>> Only deprecated with backwards compatibility the way this patch did it.
>>> That should have been obvious.
>>
>>
>> It is at least the third time I have to repeat that: we really don't care
>> about out-of-tree modules.
>>
>> Everyone MUST read Documentation/stable_api_nonsense.txt.
>
>
> Seriously, what are you talking about ???
>
> $ git grep -n TC_ACT_QUEUED include/uapi/
> include/uapi/linux/pkt_cls.h:105:#define TC_ACT_QUEUED          5
>
> This is *UAPI*, no-one is even remotely talking about out-of-tree
> kernel modules.

I am not stupid. You should figure out we can just leave its definition
by removing it, leaving the default as stolen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html