lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Apr 2015 19:54:10 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Joe Perches <joe@...ches.com>, Ian Morris <ipm@...rality.org.uk> CC: netdev@...r.kernel.org Subject: Re: [PATCH net-next 3/6] ipv6: netfilter: remove unnecessary braces Hello. On 04/25/2015 06:59 PM, Joe Perches wrote: >> Remove braces from a few if statements where not required. > trivia: >> diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c > [] >> @@ -151,9 +151,8 @@ ip6_packet_match(const struct sk_buff *skb, >> ip6info->proto); >> >> if (ip6info->proto == protohdr) { >> - if (ip6info->invflags & IP6T_INV_PROTO) { >> + if (ip6info->invflags & IP6T_INV_PROTO) >> return false; >> - } >> return true; > maybe > return (!(ip6info->invflags & IP6T_INV_PROTO)); Parens around the *return* expression are not necessary. :-) WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists