lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 26 Apr 2015 20:18:28 +0300
From:	Or Gerlitz <>
To:	Amir Vadai <>
Cc:	"David S. Miller" <>,
	Linux Netdev List <>,
	Or Gerlitz <>,
	Tal Alon <>,
	Ben Hutchings <>
Subject: Re: [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes

On Sun, Apr 26, 2015 at 5:36 PM, Amir Vadai <> wrote:
> Hi Dave,
> This small patchset fixes a small issue in the ethtool User/kernel API.
> Hash function is represented as an eight bit field, every bit represents a
> function.  Currently possible values are: 1 for Toeplitz and 2 for XOR.
> This commit changes the representation from bit flags into a value. Because
> only one hash function will be used at a time, there is no sense using bit
> flags for it.
> Since today only 2 functions are supported, and there is no user space ethtool
> that supports this feature, we can switch into values without causing any
> backward compatibility issues.
> After this patchset is applied, I will send the user space patch.
> In this occasion I added a missing validation to the hash function value.
> This patchset was applied and tested over commit 2ea2f62 ("net: fix crash in build_skb()")
> Please push this patchset to stable 3.19.y in which those two issues were introduced.

and 4.0.y too I guess?
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists