netdev - Re: [PATCH 2/2] brcmfmac: keep WiFi chip's power during system suspension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <553DF923.5070300@broadcom.com>
Date:	Mon, 27 Apr 2015 10:53:55 +0200
From:	Arend van Spriel <arend@...adcom.com>
To:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
CC:	"brudley@...adcom.com" <brudley@...adcom.com>,
	Franky Lin <frankyl@...adcom.com>,
	"meuleman@...adcom.com" <meuleman@...adcom.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	"pieterpg@...adcom.com" <pieterpg@...adcom.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"brcm80211-dev-list@...adcom.com" <brcm80211-dev-list@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] brcmfmac: keep WiFi chip's power during system suspension

On 04/27/15 07:06, Fu, Zhonghui wrote:
> Need to keep the power supply for WiFi chip during system suspension.
> Otherwise, the context of WiFi chip will be lost.

I already submitted a patch doing exactly the same thing [1]

Regards,
Arend

[1] https://patchwork.kernel.org/patch/6217391/

> Signed-off-by: Zhonghui Fu<zhonghui.fu@...ux.intel.com>
> ---
>   drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |   10 ++++++----
>   1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> index fdf8feb..03d3671 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> @@ -1251,15 +1251,17 @@ static int brcmf_ops_sdio_suspend(struct device *dev)
>   	brcmf_sdiod_freezer_on(sdiodev);
>   	brcmf_sdio_wd_timer(sdiodev->bus, 0);
>
> +	sdio_flags = MMC_PM_KEEP_POWER;
>   	if (sdiodev->wowl_enabled) {
> -		sdio_flags = MMC_PM_KEEP_POWER;
>   		if (sdiodev->pdata->oob_irq_supported)
>   			enable_irq_wake(sdiodev->pdata->oob_irq_nr);
>   		else
> -			sdio_flags = MMC_PM_WAKE_SDIO_IRQ;
> -		if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags))
> -			brcmf_err("Failed to set pm_flags %x\n", sdio_flags);
> +			sdio_flags |= MMC_PM_WAKE_SDIO_IRQ;
>   	}
> +
> +	if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags))
> +		brcmf_err("Failed to set pm_flags %x\n", sdio_flags);
> +
>   	return 0;
>   }
>
> -- 1.7.1
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html