netdev - Re: [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <553E10D1.5050505@mellanox.com>
Date:	Mon, 27 Apr 2015 13:34:57 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>
Subject: Re: [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting
 fixes

On 4/27/2015 6:02 AM, David Miller wrote:
> From: Amir Vadai <amirv@...lanox.com>
> Date: Sun, 26 Apr 2015 17:36:04 +0300
> 
>> Hash function is represented as an eight bit field, every bit represents a
>> function.  Currently possible values are: 1 for Toeplitz and 2 for XOR.
>> This commit changes the representation from bit flags into a value. Because
>> only one hash function will be used at a time, there is no sense using bit
>> flags for it.
> 
> If we ever want to add some kind of control attributes that might
> apply to any hash, we'll want flags again.
> 
> You can just enforce that only one of these hash function bits can be
> set at one time, and be done with it.
> 
Ok, re-spinning with the fix to mlx4_en only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html