netdev - Re: v3.12-stable-queue build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fv7lk2i0.fsf@x220.int.ebiederm.org>
Date:	Mon, 27 Apr 2015 10:35:51 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	David Miller <davem@...emloft.net>,
	ML netdev <netdev@...r.kernel.org>,
	Guenter Roeck <linux@...ck-us.net>, stable@...r.kernel.org
Subject: Re: v3.12-stable-queue build errors

Jiri Slaby <jslaby@...e.cz> writes:

> On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
>> Several powerpc build fail with:
>> 
>> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
>> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of
>> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration]
>>    dev_consume_skb_any(skb);
>> 
>> dev_consume_skb_any() does not exist in 3.12.
>> 
>> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'.
>
> Eric, David,
>
> what action should I take here?
>
> 1) take also:
> commit e6247027e5173c00efb2084d688d06ff835bc3b0
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Thu Dec 5 04:45:08 2013 -0800
>
>     net: introduce dev_consume_skb_any()
>
>
> 2) drop 'gianfar: Carefully free skbs in functions called by netpoll'
> from stable-3.12

This is probably the most reasonable.   KISS.

> 3) any other idea?

#define dev_consume_sky_any dev_kfree_skb_any

The correctness fix is updating the code to handle any context.  The
consume vs kfree accouting difference is not particularly interesting.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html